[Webkit-unassigned] [Bug 140911] Invoking an immediate action on link often dismisses selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140911

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #2)
> Comment on attachment 245391 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245391&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:-210
> > -    _page->setMaintainsInactiveSelection(false);
> 
> I don't think we can get rid of this one, can we?

It actually seems like dismissContentRelativeChildWindows is typically called through WKView code on cancel, but it seems best not to rely on that, so I kept this one. There is certainly no downside.

http://trac.webkit.org/changeset/179195

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150127/8abe343d/attachment-0002.html>