[Webkit-unassigned] [Bug 140496] Rename SimpleFontData to Font

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 21 21:07:54 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=140496

--- Comment #8 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 245118 did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Font.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/Font.h:143:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:235:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:236:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:240:  The parameter name "glyph" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/Font.h:258:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:139:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:193:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/platform/graphics/Font.cpp:253:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 9 in 88 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150122/f1b4af8c/attachment-0002.html>


More information about the webkit-unassigned mailing list