[Webkit-unassigned] [Bug 140722] New: Simplify CachedImage clients to avoid overriding both or either only imageChanged or notifyFinished

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140722

            Bug ID: 140722
           Summary: Simplify CachedImage clients to avoid overriding both
                    or either only imageChanged or notifyFinished
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: j.isorce at samsung.com

Created attachment 245058
  --> https://bugs.webkit.org/attachment.cgi?id=245058&action=review
CachedImage: ensure clients overrides imageChanged instead of notifyFinished

CachedImageClient defines imageChanged which is meant to be called whenever a frame of an image changes because we got more data from the network.

But some clients still override CachedResource::notifyFinished because in imageChanged it is not possible to know if the image is acutally enterly loaded or still loading.
(Indeed when imageChanged is called, isLoaded() never return true, even from CachedImage::finishLoading)

If we compare CachedImage to CachedFont, the later has all its clients that do not override notifyFinished. Indeed in CachedFont::finishLoading there is a call to setLoaded(false)
which is not there in CachedImage::finishLoading.

So the following patch tries to simplify the situation by marking CachedImageClient::notifyFinished final and making the refactoring that this change implies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150121/1672025d/attachment-0002.html>