[Webkit-unassigned] [Bug 140307] If building with ASan, copy libclang_rt.asan_osx_dynamic.dylib to the build directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 20 12:38:46 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=140307

--- Comment #8 from Dana Burkart <dburkart at apple.com> ---
(In reply to comment #6)
> Comment on attachment 244793 [details]
> New target for DumpRenderTree which copies the dylib
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244793&action=review
> 
> r- to address Mark's and Alexey's comments.
> 
> > Tools/ChangeLog:10
> > +        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add a new target which runs copy-asan-dylib.
> > +        * Scripts/copy-asan-dylib: Added. This script checks to see if we are building with asan, and
> > +        if so, copies libclang_rt.asan_osx_dynamic.dylib to the build directory.
> 
> Xcode has a built-in way to copy files; can we just use a "copy files" build
> phase instead of a build phase script?
> 
> Or do we only need to copy this when building for ASan, so we have to
> include logic in the copy files build phase?
> 

We need to not only conditionally copy the file, we need to find it in the first place. This is not quite trivial, which is why I didn't just use Xcode's built-in way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150120/9ebaefa9/attachment-0002.html>


More information about the webkit-unassigned mailing list