[Webkit-unassigned] [Bug 140495] REGRESSION(r177876): Membuster regressed ~4%

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140495

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245002|review?                     |review+
              Flags|                            |

--- Comment #6 from Andreas Kling <akling at apple.com> ---
Comment on attachment 245002
  --> https://bugs.webkit.org/attachment.cgi?id=245002
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245002&action=review

r=me

> Source/WebCore/platform/graphics/FontCascade.cpp:296
>      Vector<unsigned, 50> toRemove;
> -    FontGlyphsCache::iterator end = fontGlyphsCache().end();
> -    for (FontGlyphsCache::iterator it = fontGlyphsCache().begin(); it != end; ++it) {
> -        if (it->value->glyphs.get().hasOneRef())
> -            toRemove.append(it->key);
> +    for (auto& entry : fontGlyphsCache()) {
> +        if (entry.value->glyphs.get().hasOneRef())
> +            toRemove.append(entry.key);
>      }
>      for (unsigned i = 0; i < toRemove.size(); ++i)
>          fontGlyphsCache().remove(toRemove[i]);

Jesus man, just use removeIf(), it's not 2014 anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150120/d0c2c7b2/attachment-0002.html>