[Webkit-unassigned] [Bug 124370] Fix failed to build for Linux/MIPS64EL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124370

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244881|review?                     |review+
              Flags|                            |

--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 244881
  --> https://bugs.webkit.org/attachment.cgi?id=244881
don't use __mips64 for N64 determination.

View in context: https://bugs.webkit.org/attachment.cgi?id=244881&action=review

I’m not a platform expert, but this patch looks OK to me.

> Source/WTF/wtf/Platform.h:85
> +#if (defined(mips) || defined(__mips__) || defined(MIPS) || defined(_MIPS_) \
> +    || defined(__mips64))

This line break just makes things hard to read. We are not trying to fit in 80 columns. Please consider putting this all on one line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150120/26f7a5da/attachment-0002.html>