[Webkit-unassigned] [Bug 140307] If building with ASan, copy libclang_rt.asan_osx_dynamic.dylib to the build directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140307

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 244793
  --> https://bugs.webkit.org/attachment.cgi?id=244793
New target for DumpRenderTree which copies the dylib

View in context: https://bugs.webkit.org/attachment.cgi?id=244793&action=review

I looked at the script, but I cannot meaningfully review xcodeproj changes.

> Tools/Scripts/copy-asan-dylib:23
> +if ($should_copy_dylib) {

This should probably compare to YES.

> Tools/Scripts/copy-asan-dylib:24
> +    my $xcrun_output = `xcrun --toolchain Default clang -fsanitize=address -x c - -### 2>&1`;

Can't we use a toolchain specified by asan.xcodeproj.

> Tools/Scripts/copy-asan-dylib:28
> +    $result |= system("mkdir -p $DSTROOT/System/Library/Frameworks/WebKit.framework/Versions/A/Resources");

Why does this need to use system()? Perl is very capable of creating directories and copying.

> Tools/Scripts/copy-asan-dylib:29
> +    $result |= system("ditto $1 $DSTROOT/System/Library/Frameworks/WebKit.framework/Versions/A/Resources/libclang_rt.asan_osx_dynamic.dylib") >> 8;

I think that this is the right path when building a root (i.e. when installing), but not for normal developer builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150116/9a7ca4d0/attachment-0002.html>