[Webkit-unassigned] [Bug 140508] New: Some console messages erroneously skip the first ScriptCallStack frame when computing source locations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140508

            Bug ID: 140508
           Summary: Some console messages erroneously skip the first
                    ScriptCallStack frame when computing source locations
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: burg at cs.washington.edu
                CC: ap at webkit.org, joepeck at webkit.org,
                    nvasilyev at apple.com, timothy at apple.com
        Depends on: 140478

These wrong line numbers were previously visible in test results, but with the fix to https://bugs.webkit.org/show_bug.cgi?id=140478 this will become more apparent. This may have been happening for console messages too, though I have no test case in hand.

I suggest simplifying the logic in ConsoleMessage and ScriptCallStackFactory so that there is only one place that creates a ScriptCallStack. Clients can specifically ask for the first non-native call frame if that is necessary, i.e., when the native call frame shouldn't be shown in the console. There's no reason to decide whether to skip this when creating the call stack, as code paths already exist to filter out native frames.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150115/9d53b82b/attachment-0002.html>