[Webkit-unassigned] [Bug 140494] REGRESSION(r177075): [GTK] Creating a second web view disables accelerated compositing in existing web view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140494

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 244683 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244683&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:691
> > +    m_webPage.corePage()->settings().setAcceleratedCompositingEnabled(true);
> 
> Wouldn't it be better to enable this unconditionally in WebKitSettings's
> constructed? This looks a bit hackish.

That would be a problem if the required X extensions are not present and SetNativeSurfaceHandleForCompositing message is not sent. The web process would enter AC mode but we wouldn't render anything. I think this is the safest approach, the setting is disabled by default, and should only be enabled when the web process has a native surface handle.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150115/ed911cef/attachment-0002.html>