[Webkit-unassigned] [Bug 139151] Web Inspector: selecting Paint timeline records from sidebar does not trigger preview of paint quad

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139151

Brian Burg <burg at cs.washington.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242600|review?                     |review+
              Flags|                            |

--- Comment #8 from Brian Burg <burg at cs.washington.edu> ---
Comment on attachment 242600
  --> https://bugs.webkit.org/attachment.cgi?id=242600
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=242600&action=review

r=me

It doesn't look too spammy to me. In fact, it's kind of hard to follow the hovered row. Is there a way to add a table row hover highlight within the current design language?

> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js:279
> +        const contentColor = {r: 111, g: 168, b: 220, a: 0.66};

(Aside: I'm surprised WebInspector.Color doesn't have a .toProtocol() method)

> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js:290
> +        var rect = record.rect;

Nit: Could we put this case first and avoid detecting DOMAgent.highlightQuad?

> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js:300
> +            this._showingHighlight = false;

Nit: I would switch these lines so the member lines up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150115/e580fa44/attachment-0002.html>