[Webkit-unassigned] [Bug 140477] New: RenderLayerCompositor: Strange comparison of opacity to boolean.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140477

            Bug ID: 140477
           Summary: RenderLayerCompositor: Strange comparison of opacity
                    to boolean.
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

I receive the following warning when I build. Reviewing the line in question reveals that we are comparing a boolean (the return value of "ancestorBacking->graphicsLayer->drawsContents()") to the float returned by the style's opacity property.

This seems very strange. At the very least, we should do some casting here to make it clear that this is intentional (if it is).

            if (newStyle.opacity() != ancestorBacking->graphicsLayer()->drawsContent())
                return true;

Where:
opacity is a float
drawsContent is a boolean.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150115/8a25aa06/attachment-0002.html>