[Webkit-unassigned] [Bug 140053] Web Inspector: purge PassRefPtr from Inspector code and use Ref for typed and untyped protocol objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 14 15:00:11 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=140053

--- Comment #16 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 244128
  --> https://bugs.webkit.org/attachment.cgi?id=244128
EWS round 3

View in context: https://bugs.webkit.org/attachment.cgi?id=244128&action=review

> Source/WebCore/page/PageConsoleClient.cpp:156
> -        ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, arguments.release());
> +        ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, WTF::move(arguments));

This cannot work, we already moved out of arguments a few lines above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150114/3f544a7a/attachment-0002.html>


More information about the webkit-unassigned mailing list