[Webkit-unassigned] [Bug 140183] Failed to display background image when body is composited

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140183

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244335|review?                     |review-
              Flags|                            |

--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 244335
  --> https://bugs.webkit.org/attachment.cgi?id=244335
Render: properly update body's background image

View in context: https://bugs.webkit.org/attachment.cgi?id=244335&action=review

Good but needs to be a ref test.

> LayoutTests/ChangeLog:13
> +        * animations/animation-background-image.html: Added.

Please make this a ref test.

> Source/WebCore/rendering/RenderBox.cpp:116
> +    if (skip && bodyElementRenderer->isComposited() && documentElementRenderer->hasLayer()) {
> +        if (RenderLayerBacking* backing = downcast<RenderLayerModelObject>(documentElementRenderer)->layer()->backing())

I think this would read better as:

if (skip && bodyElementRenderer->isComposited() && documentElementRenderer->isComposited()) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150114/f2848798/attachment-0002.html>