[Webkit-unassigned] [Bug 140441] [CSSRegions] Assert failure in RenderBlock::locateFlowThreadContainingBlock when showing the render tree debug info

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140441

--- Comment #3 from Mihnea Ovidenie <mihnea at adobe.com> ---
(In reply to comment #2)
> Comment on attachment 244601 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244601&action=review
> 
> > Source/WebCore/rendering/RenderObject.cpp:1398
> > +        return downcast<RenderBlock>(*renderer).cachedFlowThreadContainingBlock();
> 
> We should also check if the cached value is dirty and return null as well
> because the value is unreliable.
> 

The current implementation does not have a dirty bit. If the value is dirty, then the cached value is null, which is covered by the proposed code.

> > Source/WebCore/rendering/RenderObject.cpp:1412
> > +            ftcb = flowThreadContainingBlockFromRenderer(containingBlock());
> 
> The information in this case may be misleading. Another option would be to
> display "N/A" instead of some values that may be inaccurate.

In this case, i attempt to retrieve the flow thread containing block for a box from its containing block cached information. If we call showRenderTree* methods before invalidating the cached flow thread information, the displayed information is still appropriate. After invalidating the cached flow thread containing block, we will not display the regions information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150114/9370e588/attachment-0002.html>