[Webkit-unassigned] [Bug 140337] [WinCairo][Video] Windows Media Foundation implementation is not completed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140337

--- Comment #5 from peavo at outlook.com ---
(In reply to comment #3)
> Comment on attachment 244411 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244411&action=review
> 
> This looks like some pretty dang good work in progress.  I wouldn't be
> opposed to having this in WebKit and it can be polished from here.  What do
> you think, Brent?
> 
> > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:212
> > +        ::MoveWindow(m_hwndVideo, rect.x(), rect.y(), rect.width(), rect.height(), FALSE);
> 
> Does this just move the child window over where the video element is
> supposed to be?  Does it draw controls below the child window?  What if the
> parent window is moved or not in the coordinates (0,0)?

Thanks for reviewing :)

I've changed this in the latest patch. The child window will be moved along with the parent, and scrolling should also work (with a little lag, though). Unfortunately, the controls are drawn beneath the child window, I think. This should be fixed by drawing individual frames directly into the main window, which the Media Foundation api supports. This should be the next step, I believe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150113/4b4599ec/attachment-0002.html>