[Webkit-unassigned] [Bug 140390] Devirtualize FontData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140390

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244519|review?                     |review+
              Flags|                            |

--- Comment #3 from Andreas Kling <akling at apple.com> ---
Comment on attachment 244519
  --> https://bugs.webkit.org/attachment.cgi?id=244519
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244519&action=review

r=me

> Source/WebCore/css/CSSSegmentedFontFace.cpp:126
> +        unsigned size = m_fontFaces.size();
> +        for (unsigned i = 0; i < size; i++) {

Range for?

> Source/WebCore/platform/graphics/FontRanges.h:47
> +    PassRefPtr<SimpleFontData> fontData() const { return m_fontData; }

This should return RefPtr (or Ref.)

> Source/WebCore/platform/graphics/FontRanges.h:57
> +    static PassRefPtr<SegmentedFontData> create() { return adoptRef(new SegmentedFontData); }

This should return Ref.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150113/dabfd372/attachment-0002.html>