[Webkit-unassigned] [Bug 140352] REGRESSION(r177075): Flickering when the WebView is realized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140352

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #9)
> (In reply to comment #3)
> 
> > > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:152
> > > +    // CWBorderPixel must be present when the depth doesn't match the parent's one.
> > > +    // See http://cgit.freedesktop.org/xorg/xserver/tree/dix/window.c?id=xorg-server-1.16.0#n703.
> > > +    windowAttributes.border_pixel = 0;
> > 
> > Why does the depth not match the parent's depth?
> > 
> > > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:155
> > > -        parent ? parent : RootWindowOfScreen(screen),
> > > +        RootWindowOfScreen(screen),
> > 
> > Is there really no way to do this without properly parenting the window?
> 
> Okay. I see how it's nice for the visual, but the depth is a property of the
> visual. Getting the depth from the visual in RedirectedXCompositeWindow will
> prevent silly mistakes like passing a depth that doesn't match the visual. I
> would really prefer using XGetVisualInfo in RedirectedXCompositeWindow or to
> simply use GDK there.

XGetVisualInfo returns the list of all available visuals, that's already done by GTK+, and gdk_visual_get_depth returns the already cached value for the current visual, so we don't need to iterate the visuals again just ot get the depth. We already removed the GDK dependency in RedirectedXCompositeWindow. I don't think passing the depth is such a big deal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150113/478a6d2c/attachment-0002.html>