[Webkit-unassigned] [Bug 140352] REGRESSION(r177075): Flickering when the WebView is realized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140352

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #6)
> Comment on attachment 244437 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244437&action=review
> 
> > Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:148
> > +    windowAttributes.colormap = XCreateColormap(display, RootWindowOfScreen(screen), visual, AllocNone);
> 
> Don't you need to call XFreeColormap once the window is released in
> ::~RedirectedXCompositeWindow ?

Good point! But I don't think we need to wait until the RedirectedXCompositeWindow is destroyed, I think we can free the colormap after creating the second window.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150113/ee361a02/attachment-0002.html>