[Webkit-unassigned] [Bug 140352] REGRESSION(r177075): Flickering when the WebView is realized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140352

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 244437 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=244437&action=review
> > 
> > > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:323
> > > +        GdkVisual* visual = gdk_window_get_visual(parentWindow);
> > >          priv->redirectedWindow = RedirectedXCompositeWindow::create(
> > >              GDK_DISPLAY_XDISPLAY(display),
> > > -            parentWindow ? GDK_WINDOW_XID(parentWindow) : 0,
> > > -            IntSize(1, 1),
> > > +            GDK_VISUAL_XVISUAL(visual),
> > > +            gdk_visual_get_depth(visual),
> > 
> > You are no longer handling the null parentWindow case here?
> 
> hmm, widgets must be inside a toplevel window (or be a toplevel) before
> being realized. I'll check if this causes problems with uwing a web view
> inside a popup window, for example.
> 

I've checked this and the window shoulnd't be NULL at this point, there are a lot of widgets in GTK that call gtk_widget_get_parent_window() in the realize method without checking the return value too. I don't think we need an ASSERT(), because gdk_window_get_visual() has a g_return macro if the passed in window is not a GdkWindow, so I wouldn't change anything in the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150113/604f6521/attachment-0002.html>