[Webkit-unassigned] [Bug 140352] REGRESSION(r177075): Flickering when the WebView is realized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140352

--- Comment #3 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 244437
  --> https://bugs.webkit.org/attachment.cgi?id=244437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244437&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:323
> +        GdkVisual* visual = gdk_window_get_visual(parentWindow);
>          priv->redirectedWindow = RedirectedXCompositeWindow::create(
>              GDK_DISPLAY_XDISPLAY(display),
> -            parentWindow ? GDK_WINDOW_XID(parentWindow) : 0,
> -            IntSize(1, 1),
> +            GDK_VISUAL_XVISUAL(visual),
> +            gdk_visual_get_depth(visual),

You are no longer handling the null parentWindow case here?

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:131
> -std::unique_ptr<RedirectedXCompositeWindow> RedirectedXCompositeWindow::create(Display* display, Window parent, const IntSize& size, std::function<void()> damageNotify)
> +std::unique_ptr<RedirectedXCompositeWindow> RedirectedXCompositeWindow::create(Display* display, Visual* visual, int depth, std::function<void()> damageNotify)
>  {
> -    return supportsXDamageAndXComposite(display) ? std::unique_ptr<RedirectedXCompositeWindow>(new RedirectedXCompositeWindow(display, parent, size, damageNotify)) : nullptr;
> +    return supportsXDamageAndXComposite(display) ? std::unique_ptr<RedirectedXCompositeWindow>(new RedirectedXCompositeWindow(display, visual, depth, damageNotify)) : nullptr;

I think we don't need to change the arguments here. You can get a window's visual and depth using XGetWindowAttributes.

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:152
> +    // CWBorderPixel must be present when the depth doesn't match the parent's one.
> +    // See http://cgit.freedesktop.org/xorg/xserver/tree/dix/window.c?id=xorg-server-1.16.0#n703.
> +    windowAttributes.border_pixel = 0;

Why does the depth not match the parent's depth?

> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:155
> -        parent ? parent : RootWindowOfScreen(screen),
> +        RootWindowOfScreen(screen),

Is there really no way to do this without properly parenting the window?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150112/1b63ff7c/attachment-0002.html>