[Webkit-unassigned] [Bug 140116] [GStreamer][MSE] ASSERT in MediaSourceGStreamer::addSourceBuffer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 9 02:47:05 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=140116

--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 244262
  --> https://bugs.webkit.org/attachment.cgi?id=244262
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244262&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.cpp:79
> +    RefPtr<SourceBufferPrivateGStreamer> buffer = SourceBufferPrivateGStreamer::create(this);
> +    m_sourceBuffers.add(buffer.get());
> +    sourceBufferPrivate = buffer;

I'm confused about the ownership now. In the previous patch you kept a reference in the Vector, why are you using raw pointers now? Is removeSourceBuffer always called before the SourceBufferPrivate object is deleted?

> Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:86
> +    m_mediaSource->removeSourceBuffer(this);
> +    m_mediaSource->client().removedFromMediaSource(this);

hmm, now that I see this. It looks a bit weird to me that MediaSourceGStreamer::addSourceBuffer() calls MediaSourceClientGStreamer::addSourceBuffer() but removedFromMediaSource is called here instead of in MediaSourceGStreamer::removeSourceBuffer(). Also why does MediaSourceClientGStreamer::removedFromMediaSource() receive a PassRefPtr?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150109/1dc9a443/attachment-0002.html>


More information about the webkit-unassigned mailing list