[Webkit-unassigned] [Bug 126433] webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126433

Philip Chimento <philip.chimento at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244131|                            |review?
              Flags|                            |

--- Comment #1 from Philip Chimento <philip.chimento at gmail.com> ---
Created attachment 244131
  --> https://bugs.webkit.org/attachment.cgi?id=244131&action=review
Patch

Here's a simple patch to remove CoreFoundation.h for the GTK port. It applies to the 2.4.x branch since I don't believe this is an issue on 2.6.x.

Would this be able to be reviewed for 2.4.8?

For completeness, here's the output I had for this failure:

In file included from Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:30:
In file included from ./Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:23:
In file included from ./Source/JavaScriptCore/API/JSStringRef.h:29:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/JSValueRef.h:1:
In file included from ./Source/JavaScriptCore/API/JSValueRef.h:30:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:1:
In file included from ./Source/JavaScriptCore/API/WebKitAvailability.h:31:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:38:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:68:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:552:3: error:
      reference to 'Fixed' is ambiguous
  Fixed               bottom;
  ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:184:41: note:
      candidate found by name lookup is 'Fixed'
typedef SInt32                          Fixed;
                                        ^
./Source/WebCore/platform/Length.h:38:30: note: candidate found by name lookup
      is 'WebCore::LengthType::Fixed'
    Auto, Relative, Percent, Fixed,
                             ^
In file included from Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:30:
In file included from ./Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:23:
In file included from ./Source/JavaScriptCore/API/JSStringRef.h:29:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/JSValueRef.h:1:
In file included from ./Source/JavaScriptCore/API/JSValueRef.h:30:
In file included from ./Source/JavaScriptCore/ForwardingHeaders/JavaScriptCore/WebKitAvailability.h:1:
In file included from ./Source/JavaScriptCore/API/WebKitAvailability.h:31:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:38:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:68:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:570:9: error:
      reference to 'Style' is ambiguous
typedef Style                           StyleField;
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/include/MacTypes.h:568:41: note:
      candidate found by name lookup is 'Style'
typedef unsigned char                   Style;
                                        ^
./Source/WebCore/style/StyleResolveTree.h:37:11: note: candidate found by name
      lookup is 'WebCore::Style'
namespace Style {
          ^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150107/9a9bd648/attachment-0002.html>