[Webkit-unassigned] [Bug 140123] REGRESSION (r177876): 35% regression in Parser/html5-full-render
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 6 10:45:11 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=140123
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #244053|review? |review+
Flags| |
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 244053
--> https://bugs.webkit.org/attachment.cgi?id=244053
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=244053&action=review
> Source/WebCore/platform/graphics/SimpleFontData.cpp:443
> RefPtr<SimpleFontData> SimpleFontData::systemFallbackFontDataForCharacter(UChar32 c, const FontDescription& description, bool isForPlatformFont) const
Would be nice to name it "character" instead of "c".
> Source/WebCore/platform/graphics/SimpleFontData.cpp:455
> + if (c <= 0xFFFF) {
I think we should use U_IS_BMP here.
> Source/WebCore/platform/graphics/SimpleFontData.cpp:480
> + Vector<std::pair<UChar32, unsigned>> toRemove;
Inline capacity here, maybe?
> Source/WebCore/platform/graphics/SimpleFontData.cpp:484
> + for (auto& entry : characterMap) {
> + if (entry.value == this)
> + toRemove.append(entry.key);
> + }
Should we have a map in the reverse direction to avoid this iteration?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150106/83a73fd0/attachment-0002.html>
More information about the webkit-unassigned
mailing list