[Webkit-unassigned] [Bug 140124] Rename SimpleFontData::AdditionalFontData to SimpleFontData::SVGData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140124

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244061|review?                     |review+
              Flags|                            |

--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 244061
  --> https://bugs.webkit.org/attachment.cgi?id=244061
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244061&action=review

>> Source/WebCore/platform/graphics/SimpleFontData.h:179
>> +    bool isSVGFont() const { return !!m_svgData; }
> 
> Is the !! necessary? Won't the bool cast be automatic?

It won't since the std::unique_ptr bool operator is explicit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150106/d7b9b7b8/attachment-0002.html>