[Webkit-unassigned] [Bug 138562] [GStreamer] GstGL support in the video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138562

--- Comment #17 from Zan Dobersek <zandobersek at gmail.com> ---
Comment on attachment 243795
  --> https://bugs.webkit.org/attachment.cgi?id=243795
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243795&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:308
> +    GstMemory* bufferMemory;

This can be moved into the scope of the gst_buffer_n_memory(buffer) >= 1 if-statement.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:316
> +            GstGLMemory* glMemory = reinterpret_cast<GstGLMemory*>(bufferMemory);

I usually go with 'auto* <variable>' when using reinterpret_cast, but as you prefer really.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:320
> +            gboolean copied = gst_gl_memory_copy_into_texture(glMemory, textureID, textureType, size.width(), size.height(), GST_VIDEO_INFO_PLANE_STRIDE(&videoInfo, 0), true /* respecify */);
> +            if (copied) {

If you find it readable enough, gst_gl_memory_copy_into_texture() call could sit in the if-statement directly.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:385
> +    if (priv->pool)
> +        gst_object_unref(priv->pool);
> +    priv->pool = nullptr;

This ...

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:393
> +    if (priv->upload) {
> +        gst_object_unref(priv->upload);
> +        priv->upload = nullptr;
> +    }

... should match with this, specifically whether priv->upload should be nullified unconditionally, or priv->pool nullified conditionally.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:496
> +    GstAllocator* allocator = nullptr;
> +    GstAllocationParams params;

These two could be declared in the later #if block, where they are used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150106/0ff1bd80/attachment-0002.html>