[Webkit-unassigned] [Bug 140101] New: [TexMap]TextureMapperLayer - avoiding multiple regions in paintUsingOverlapRegions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140101

            Bug ID: 140101
           Summary: [TexMap]TextureMapperLayer - avoiding multiple regions
                    in paintUsingOverlapRegions
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: abaldeva at ea.com

Created attachment 244009
  --> https://bugs.webkit.org/attachment.cgi?id=244009&action=review
1 pixel offset overlapping region

Hi,

In TextureMapperLayer::paintUsingOverlapRegions, there is a check to avoid dividing the area between overlapping and nonoverlapping. The current check is 
if (overlapRegion.bounds().size().area() > nonOverlapRegion.bounds().size().area())

However, I think it is incorrect. If the overlap region is just 1 pixel small from all the 4 side, this check would not catch that. Attached an html that reproduces the issue. 

Seems to me that the correct check should be 
if (overlapRegion.totalArea() > nonOverlapRegion.totalArea)

Thoughts?
Arpit

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150105/38060533/attachment-0002.html>