[Webkit-unassigned] [Bug 140081] Font::primaryFontData() should return a reference

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140081

--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 243978 [details]
> > patch2
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=243978&action=review
> > 
> > A tiny bit sad that something used this often got a little longer, but I
> > suppose it’s strange that a font has a function that returns “a font”.
> 
> Yeah. We might even want to rename Font to something like StyleFont (since
> it is essentially CSS font definition) and FontData to Font.
> 
> > Do we even need a function for this?
> 
> Not really. I'll get rid of it.

I actually think that this is a good function to have. It lightens the cognitive load of code that calls this function, and I don't think there is any information lost between just using the name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150105/5b65f17c/attachment-0002.html>