[Webkit-unassigned] [Bug 139813] [MSE] Implement per TrackBuffer buffered.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 5 10:04:27 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=139813

--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 243548
  --> https://bugs.webkit.org/attachment.cgi?id=243548
patch_wip_per_trackbuffer_v1

View in context: https://bugs.webkit.org/attachment.cgi?id=243548&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:195
> +        auto& ranges = trackBuffer.m_buffered->ranges();
> +        unsigned length = ranges.length();
> +        if (length)
> +            highestEndTime = std::max(highestEndTime, ranges.end(length - 1));
> +    }

PlatformTimeRanges has a maximumBufferedTime() which would work well here.

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:213
> +        if (ended && trackRanges.length())
> +            trackRanges.add(trackRanges.start(trackRanges.length() - 1), highestEndTime);

Again, maximumBufferedTime() could be used here.

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1553
> +    cacheBuffered();

recalculateBuffered()?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150105/962eaaad/attachment-0002.html>


More information about the webkit-unassigned mailing list