[Webkit-unassigned] [Bug 139179] HTMLSelectElement add() should support index as second argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139179

--- Comment #55 from Shivakumar J M <shiva.jm at samsung.com> ---
(In reply to comment #54)
> When it comes to preserving the old Objective-C API, this should be done
> with conditionals specific to Objective-C and should have as little effect
> as possible on anything outside the IDL file. For example, for Objective-C
> we can just have the add function take an HTMLOptionElement, but we can
> probably get away without having anything in the actual DOM source files,
> just the IDL file.
> 
> Because the tests no longer reset anything, now if any one test fails, all
> the subsequent ones will fail too. We want each test to be as independent as
> possible unless there is a good reason to make them depend on each other.


So, if i understand correctly, we can just retain old add() api with HTMLOptionElement in .idl file and do not have any definition/declaration in .h  and source files. We can retain 2 new add() apis added in .idl files under #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT block and have definition/declaration for only these two new add() apis in .h and source files.

So current changes in both .idl files are ok, we just need to remove old add() api definition/declaration in .h and source files, is it right ?.


Ok, will make each test independent, thought if we do not reset, we can just read expected.txt to know tests and results. 

Do we need to print list contents on each reset (i.e for each tests ?) Or printing list contents at beginning only once is fine ?.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150103/aed3823d/attachment-0002.html>