[Webkit-unassigned] [Bug 139179] HTMLSelectElement add() should support index as second argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139179

--- Comment #53 from Shivakumar J M <shiva.jm at samsung.com> ---
patch has passed build and tests:

1) as per spec now arg1 default value is undefined (Default=Undefined) and arg1 is not optional and is not nullable. arg2 default value is undefined (Default=Undefined) and arg2 is optional and is nullable in HTMLSelectElement.idl

2) as per spec now arg1 default value is undefined (Default=Undefined) and arg1 is not optional and is not nullable. arg2 default value is undefined (Default=Undefined) and arg2 is optional and is nullable in HTMLOptionsCollection.idl

3) But agr2 in HTMLOptionsCollection.idl is using "unsigned long" for index parameter, if we use just "long" it will give build error as : ENABLE_WEBVTT_REGIONS ENABLE_XHR_TIMEOUT ENABLE_XSLT ENABLE_FTL_JIT  ENABLE_SATURATED_LAYOUT_ARITHMETIC   LANGUAGE_OBJECTIVE_C" --generator ObjC --supplementalDependencyFile ./SupplementalDependencies.txt WebCore/html/HTMLTableElement.idl
Public API change. There are missing public properties and/or methods from the "DOMHTMLOptionsCollection" class.
- (void)add:(DOMHTMLOptionElement *)option index:(unsigned)index;
Died at WebCore/bindings/scripts//CodeGeneratorObjC.pm line 386.
make: *** [DOMHTMLOptionsCollection.h] Error 255

4) We have 2 add functions with "unsigned long index" as arg2 in HTMLOptionsCollection.idl, one to suppourt HTMLOptionElement and other to
suppourt HTMlOptGroupElement. But tried with "[RaisesException] void add([Default=Undefined] HTMlOptGroupElement element, [Default=Undefined]  
optional unsigned long index);", it give build error, so using HTMLElement instead of HTMlOptGroupElement.

5) if add is called with no inputs add(), it should throw not enough arguments, same as other browsers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150102/f34c0ede/attachment-0002.html>