[Webkit-unassigned] [Bug 142138] Update inline media element apperance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142138

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247615|review?                     |review+
              Flags|                            |

--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 247615
  --> https://bugs.webkit.org/attachment.cgi?id=247615
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247615&action=review

Looks OK. I think Eric is about to land a big change soon so you two should coordinate.

It would be nice if we could use ctx.scale(dpr, dpr) rather than multiply by dpr everywhere, which I think should be possible.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:184
> +    visibility: hidden;

Did you swap to visibility rather than opacity because of hit testing? I wonder if we could just do display none?

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:372
> +    background-size: 100% 17px !important;

I think this should be 100% 100%. You've already set height to be 17px above, so you don't want to keep them in sync manually.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:999
> +    addRoundedRect: function(ctx, x, y, width, height, radius) {
> +        ctx.moveTo(x + radius, y);
> +        ctx.arcTo(x + width, y, x + width, y + radius, radius);
> +        ctx.lineTo(x + width, y + height - radius);
> +        ctx.arcTo(x + width, y + height, x + width - radius, y + height, radius);
> +        ctx.lineTo(x + radius, y + height);
> +        ctx.arcTo(x, y + height, x, y + height - radius, radius);
> +        ctx.lineTo(x, y + radius);
> +        ctx.arcTo(x, y, x + radius, y, radius);
> +    },

If this is the same as the one in ControllerIOS then we should be able to remove it from there, since this is the base class.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1025
> +        var midY = height / 2;
> +        var timelineHeight = 3 * dpr;
> +        var trackHeight = dpr;
> +        var scrubberWidth = 3 * dpr;
> +        var scrubberHeight = 15 * dpr;
> +        var borderSize = 2 * dpr;

Rather than multiplying by dpr everywhere, you might be better off applying a scale on the context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150301/8fb0421a/attachment-0002.html>