[Webkit-unassigned] [Bug 142071] New: BytecodeGenerator::constLocal() behaves identically to BytecodeGenerator::local() for the purposes of its one caller

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 19:16:40 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=142071

            Bug ID: 142071
           Summary: BytecodeGenerator::constLocal() behaves identically to
                    BytecodeGenerator::local() for the purposes of its one
                    caller
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

So, remove constLocal().

The behavioral differences are:

- constLocal() doesn't have a special case for "this" that overrides other checks like the shouldOptimizeLocals() check.  But the one user of constLocal() is for the "const x" expression, and "const this" doesn't parse.

- constLocal() won't createArgumentsIfNecessary() for "arguments".  But it's harmless if it does, since its one user assigns to the local.

So, we can remove constLocal() and make its one caller use local() instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150227/d22837a5/attachment-0002.html>


More information about the webkit-unassigned mailing list