[Webkit-unassigned] [Bug 141862] AX: Expose caret browsing preference to accessibility API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141862

--- Comment #15 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 247170
  --> https://bugs.webkit.org/attachment.cgi?id=247170
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247170&action=review

Looks like its failing on linux
../../Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:218:63: error: no 'void WTR::AccessibilityUIElement::clearSelectedTextMarkerRange()' member function declared in class 'WTR::AccessibilityUIElement'
 void AccessibilityUIElement::clearSelectedTextMarkerRange(void) { }

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1413
> +void AccessibilityUIElement::resetSelectedTextMarkerRange(void)

the (void) as an argument should be unnecessary

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1703
> +        { "caretBrowsingEnabled", getCaretBrowsingEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },

caretBrowsingEnabled should probably be a property rather than a function

> Tools/DumpRenderTree/AccessibilityUIElement.h:255
> +    void resetSelectedTextMarkerRange(void);

ditto about void

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1586
> +    if (start) {

you should use the early return idiom here which is preferred

if (!start)
    return;

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1587
> +        NSArray* textMarkers = [NSArray arrayWithObjects:start, start, nil];

I think @[ start, start ]

might be nicer here

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1589
> +        if (textMarkerRange) {

ditto about early return

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150224/d2a5386b/attachment-0002.html>