[Webkit-unassigned] [Bug 140261] Null ptr crash in WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 22 18:41:03 PST 2015


--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 246514
  --> https://bugs.webkit.org/attachment.cgi?id=246514

View in context: https://bugs.webkit.org/attachment.cgi?id=246514&action=review

> Source/WebCore/rendering/RenderView.cpp:962
> -            && os->selectionState() != SelectionNone) {
> +            && os->selectionState() != SelectionNone && os->containingBlock()) {

It seems a little fragile to check for this condition here.
e.g. RenderView::applySubtreeSelection has a similar check although that one probably won't be called with a null containingBlock.
Perhaps we can extract a helper inline function?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150223/d1dd7ce6/attachment-0002.html>

More information about the webkit-unassigned mailing list