[Webkit-unassigned] [Bug 141877] Web Inspector: split out CSSAgent wrapper classes to fix protocol layering violation and cruft

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 22 07:36:50 PST 2015


--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 247080
  --> https://bugs.webkit.org/attachment.cgi?id=247080

View in context: https://bugs.webkit.org/attachment.cgi?id=247080&action=review

Looks nice! I'll defer to others for this review, but I found two little nits up front.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:201
> +        return String::format("SetStyleSheetText %" PRIu64, m_ruleSet->identifier());

%llu instead of PRIu64? I had to Google it.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:555
> +                CSSStyleDeclaration* style = ruleSet ? ruleSet->inlineStyle() : nullptr;
> +                if (style)

Nit: One line.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150222/4b72ab1a/attachment-0002.html>

More information about the webkit-unassigned mailing list