[Webkit-unassigned] [Bug 134414] Web Inspector: Add a setting for clearing the console on page reload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134414

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246915|review?                     |review+
              Flags|                            |

--- Comment #6 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 246915
  --> https://bugs.webkit.org/attachment.cgi?id=246915
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246915&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:75
> +    this._clearLogOnReloadSetting = new WebInspector.Setting("clear-log-on-reload", false);

We might want to default it to true.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:343
> +        var clearLogOnReloadUIString = WebInspector.UIString("Clear Log on Reload");
> +
> +        if (this._clearLogOnReloadSetting.value) 
> +            clearLogOnReloadUIString = WebInspector.UIString("Keep Log on Reload");

Nit: Could be one line: this._clearLogOnReloadSetting.value ? WebInspector.UIString("Keep Log on Reload") : WebInspector.UIString("Clear Log on Reload");

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150220/963d87f4/attachment-0002.html>