[Webkit-unassigned] [Bug 141154] [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141154

--- Comment #9 from Grzegorz Czajkowski <g.czajkowski at samsung.com> ---
Comment on attachment 246658
  --> https://bugs.webkit.org/attachment.cgi?id=246658
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246658&action=review

> Source/WebKit2/ChangeLog:7
> +

What to be nice to describe what is the purpose of this change.

> Source/WebKit2/ChangeLog:10
> +        * PlatformGTK.cmake: Ditto.

According to your description, this line should go above.

> Source/WebKit2/PlatformEfl.cmake:83
> +    UIProcess/API/efl/WebsiteDataStoreEFL.cpp

Try to keep alphabetical order.

> Source/WebKit2/UIProcess/API/efl/WebsiteDataStoreEFL.cpp:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

Apple ?

> Source/WebKit2/UIProcess/API/efl/WebsiteDataStoreEFL.cpp:13
> + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''

Please use BSD license.

> Source/WebKit2/UIProcess/API/efl/WebsiteDataStoreEFL.cpp:27
> +#include "APIWebsiteDataStore.h"

An empty line is required here.

> Source/WebKit2/UIProcess/API/efl/WebsiteDataStoreEFL.cpp:36
> +    const String& path = String::fromUTF8(efreet_data_home_get()) + "/" +  directoryName;

Can we use more WebKitTestRunner specific path? How about taking it from DUMPRENDERTREE_TEMP? Ossy and Gyuyoung, what's your take on it?

> Source/WebKit2/UIProcess/API/efl/WebsiteDataStoreEFL.cpp:48
> +    configuration.localStorageDirectory = websiteDataDirectoryFileSystemRepresentation("LocalStorage");

Is this needed? Seems strange that we partially implement it. Either ensure all storage paths here or remove local storage path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150218/d21e665f/attachment-0002.html>