[Webkit-unassigned] [Bug 141563] [EFL] Implement WebView::rootViewToScreen.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 16 16:42:03 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=141563

--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 246523
  --> https://bugs.webkit.org/attachment.cgi?id=246523
[EFL] Implement WebView::rootViewToScreen.

View in context: https://bugs.webkit.org/attachment.cgi?id=246523&action=review

I don't object to implement new function. However I think you need to explain why this function is needed for us.

> Source/WebKit2/ChangeLog:8
> +        All of these are just glue except EwkView::rootViewToScreen.

Could you explain what is a role of rootViewToScreen ?

> Source/WebKit2/UIProcess/WebPageProxy.h:1104
>      void screenToRootView(const WebCore::IntPoint& screenPoint, WebCore::IntPoint& windowPoint);

If you need to use rootViewToScreen(), don't we need to support screenToRootView() as well ?

> Source/WebKit2/UIProcess/WebPageProxy.h:-1104
> -    void rootViewToScreen(const WebCore::IntRect& viewRect, WebCore::IntRect& result);

This move should be approved by WK2 owner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150217/84000567/attachment-0002.html>


More information about the webkit-unassigned mailing list