[Webkit-unassigned] [Bug 141641] [GTK] WebKitFrame objects are never released

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141641

--- Comment #4 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 246647
  --> https://bugs.webkit.org/attachment.cgi?id=246647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246647&action=review

>>> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:123
>>> +    webFrameMap().remove(webFrame);
>> 
>> This should probably be called webkitFrameDestroyed or webkitFrameDestroyedCallback, I think. It doesn't destroy the frame, it just responds to the destruction.
> 
> It's confusing, it responds to a WebCore::Frame destruction to destroy the WebKitFrame object. But I agree it's confusing, webFrameDestroyed() could work better.

webFrameDestroyed sounds like a good name as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150216/8ea668da/attachment-0002.html>