[Webkit-unassigned] [Bug 141641] [GTK] WebKitFrame objects are never released

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141641

--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 246647
  --> https://bugs.webkit.org/attachment.cgi?id=246647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246647&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:81
> +class WebKitFrameWrapper final: public FrameDestructionObserver {

I wonder if it makes sense to simply add the FrameDestructionObserver as a member of WebKitFrame? I worry about the possibility of introducing reference cycles, by wrapping the frame itself.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:123
> +static void webkitFrameDestroy(WebFrame* webFrame)
> +{
> +    webFrameMap().remove(webFrame);

This should probably be called webkitFrameDestroyed or webkitFrameDestroyedCallback, I think. It doesn't destroy the frame, it just responds to the destruction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150216/b441ea79/attachment-0002.html>