[Webkit-unassigned] [Bug 141613] [Mac] Possible DDActionContext leaks, RetainPtr cleanup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141613

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246610|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 246610
  --> https://bugs.webkit.org/attachment.cgi?id=246610
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246610&action=review

> Source/WebKit/mac/WebView/WebActionMenuController.mm:280
> +    RetainPtr<DDActionContext> actionContext = adoptNS([allocDDActionContextInstance() init]);

Nothing shady about it, it's just wrong. Good catch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150215/a2aa0b03/attachment-0002.html>