[Webkit-unassigned] [Bug 140575] Native Bindings Descriptors are Incomplete

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 13 12:53:36 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=140575

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 246543
  --> https://bugs.webkit.org/attachment.cgi?id=246543&action=review
[PATCH] Approach #1

No tests written yet, but this produces expected results for me:

  js> Object.getOwnPropertyDescriptor(MouseEvent.prototype, "altKey").get === Object.getOwnPropertyDescriptor(MouseEvent.prototype, "altKey").get
  true

  js> mouseEvent.altKey
  false

  js> getter = Object.getOwnPropertyDescriptor(MouseEvent.prototype, "altKey").get
  function altKey() {
      [native code]
  }

  js> getter.call(mouseEvent)
  false

Is this approach reasonable?

Things to look into next:
  - move JSValues off of CustomGetterSetter and into a WeakGCMap
  - tests (like what I have above)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150213/0993905f/attachment-0002.html>


More information about the webkit-unassigned mailing list