[Webkit-unassigned] [Bug 141567] WebGL: Destroy the GLContext is a GPU restart has been detected.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 13 11:12:21 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=141567
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 246534
--> https://bugs.webkit.org/attachment.cgi?id=246534
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=246534&action=review
> Source/WebCore/platform/graphics/mac/WebGLLayer.mm:93
> + GLint restartStatus = 0;
> + CGLGetParameter(glContext, kCGLCPGPURestartStatus, &restartStatus);
> + if (restartStatus == kCGLCPGPURestartStatusCaused || restartStatus == kCGLCPGPURestartStatusBlacklisted) {
> + CGLDestroyContext(glContext);
> + return;
> + }
> +
As discussed in IRC, I think we need a little more intelligence here.
1. Check that this triggers a WebGL context lost (or make sure that this does that)
2. Ensure a page doesn't keep recreating the context in this case and submitting the same bad data. Maybe allow 3 lost contexts before crashing the process?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150213/ce449b8d/attachment-0002.html>
More information about the webkit-unassigned
mailing list