[Webkit-unassigned] [Bug 141492] New: extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 11 14:16:57 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=141492

            Bug ID: 141492
           Summary: extract-localizable-strings.pl shouldn't update the
                    target file if the contents haven't changed
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mrowe at apple.com

extract-localizable-strings.pl is typically run unconditionally during the build since it's difficult to get the dependencies right. The current behavior results in the output file always being updated, which results in Xcode always needing to copy the file into the framework. This has a flow-on effect of causing any dependent targets to be relinked against the framework. There are two ways to address this:
1) Only run extract-localizable-strings.pl if any of the files it considers have changed. This is difficult to arrange for with Xcode's build system, and would be cumbersome even with make.
2) Only update the target file if the new localizable strings are different from the existing localizable strings.

This patch will take option 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150211/c55ec547/attachment-0002.html>


More information about the webkit-unassigned mailing list