[Webkit-unassigned] [Bug 140667] [WinCairo] Accelerated compositing should be disabled when graphics card does not support it.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140667

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #244974|review?                     |review-
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 244974
  --> https://bugs.webkit.org/attachment.cgi?id=244974
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244974&action=review

I could see this making things a little harder to debug.  If we run into a problem in the future, we would also have to ask ourselves if it is a problem with the accelerated path or not.  Doesn't DirectX have a non-graphics-card implementation that ideally behaves the same, but slower?  Couldn't we use this through ANGLE instead of OpenGL?  If that's infeasible, then this is definitely the way to go.

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:248
> +bool AcceleratedCompositingContext::acceleratedCompositingAvailable()

This and the declaration should probably also be inside #if USE(TEXTURE_MAPPER_GL)

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:263
> +        DestroyWindow(testWindow);

::DestroyWindow here and elsewhere

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150211/f338bec7/attachment-0002.html>