[Webkit-unassigned] [Bug 141446] WebGL2: Make sure various WebGL1 extensions promoted to core on now enabled by default.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141446

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246346|                            |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 246346
  --> https://bugs.webkit.org/attachment.cgi?id=246346
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246346&action=review

r=me, but please deal with the missing Bugzilla entry?

> Source/WebCore/ChangeLog:4
> +        rdar://problem/19633715.

Please file a related Bugzilla entry as well.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1151
> +                maxIndex = std::max(maxIndex, static_cast<int>(p[i]));

These snippets of code are scattered all through these WebGL classes. Couldn't we make these into templates of some kind to simplify the code?

Although, I guess this is just code moved from elsewhere. But could we do a clean-up pass to reduce some of this code duplication?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150211/923c2829/attachment-0002.html>