[Webkit-unassigned] [Bug 140664] Web Inspector: Make collapsed sidebars undraggable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140664

Brian Burg <burg at cs.washington.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burg at cs.washington.edu

--- Comment #11 from Brian Burg <burg at cs.washington.edu> ---
(In reply to comment #10)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Comment on attachment 246242 [details]
> > > Patch (using display: none)
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=246242&action=review
> > > 
> > > > Source/WebInspectorUI/UserInterface/Views/Sidebar.js:54
> > > > +    this._widthBeforeResize = 0;
> > > > +    this._resizerMouseDownX = 0;
> > 
> > A long while ago I read somewhere that it’s better to define all instance
> > properties in constructor since it will allocate a memory during allocation
> > and also make property access a tad faster. I don’t know if it’s still
> > relevant or applicable to JavaScriptCore.
> 
> s/during allocation/during instantiation/

I think the rationale for current style is that it's easier to read. It may be marginally faster to unconditionally define the property, but the inspector's performance is 99% dominated by layout and painting. So I wouldn't clutter the constructors unless there's evidence it's a performance problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150210/5f2b94b3/attachment-0002.html>