[Webkit-unassigned] [Bug 141318] WebGL 2: Texture call format, internal format, and type validation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 12:26:19 PST 2015


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #246225|review?                     |review+
              Flags|                            |

--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 246225
  --> https://bugs.webkit.org/attachment.cgi?id=246225

View in context: https://bugs.webkit.org/attachment.cgi?id=246225&action=review

r=me. It would be nice if the function declarations could be more inline with our coding style, though I know much of this is code being moved from one file to another.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1014
> +void WebGL2RenderingContext::texSubImage2D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset,

It's weird that this is broken into multiple lines, but the other functions are on the same line.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1125
> +    GC3Denum format, GC3Denum type)

Ditto. So many lines!

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:498
> +    GC3Denum format, GC3Denum type)

So many lines for this function declaration!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150209/ebc7e601/attachment-0002.html>

More information about the webkit-unassigned mailing list