[Webkit-unassigned] [Bug 141391] New: AX: [Win] OBJID_CLIENT comparisons broken in 64-bit Builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141391

            Bug ID: 141391
           Summary: AX: [Win] OBJID_CLIENT comparisons broken in 64-bit
                    Builds
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org
                CC: webkit-bug-importer at group.apple.com

In all builds (64-bit and 32-bit), OBJID_CLIENT is defined as (LONG) 0xFFFFFFFC. However, testing indicates that the lParam value passed to WebKit from the operating system is sometimes passed as 0x0FFFFFFFC, and sometimes as 0xFFFFFFFFFFFFFFFC (depending on client software). This is probably a bug at the client program level (or perhaps even Windows itself), but we can guard against as follows:

Instead of checking:

lParam != OBJID_CLIENT

we can truncate the value:

static_cast<LONG>(lParam) != OBJID_CLIENT

This will have no effect on our 32-bit builds, and ensure that our 64-bit builds are insulated against this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150209/18158697/attachment-0002.html>