[Webkit-unassigned] [Bug 140183] Failed to display background image when body is composited

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 09:11:19 PST 2015


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #246264|review?                     |review+
              Flags|                            |

--- Comment #36 from Darin Adler <darin at apple.com> ---
Comment on attachment 246264
  --> https://bugs.webkit.org/attachment.cgi?id=246264
Render: properly update body's background image

View in context: https://bugs.webkit.org/attachment.cgi?id=246264&action=review

> LayoutTests/compositing/backgrounds/background-image-with-negative-zindex-expected.html:17
> +<body style="background-image: url(../resources/apple.jpg);">

A little strange to have all the rest of the body style in the <style> and this one property here on the element.

> Source/WebCore/rendering/RenderLayerBacking.cpp:1921
>      if ((changeType == BackgroundImageChanged) && canCreateTiledImage(renderer().style()))
> -        updateGeometry();
> +        // Both update geometry and set content needs redisplay.
> +        updateAfterLayout(NeedsFullRepaint | IsUpdateRoot);

WebKit coding style requires braces around the body of the if statement in a case like this. The presence/absence of braces is based on the number of textual lines, not the number of statements.

The comment here is not great. We want our comments to answer the question “why”, not say what the code does.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150209/f0c45d74/attachment-0002.html>

More information about the webkit-unassigned mailing list